chrome/browser/extensions/api/usb/usb_apitest.cc - Issue 11117011: Keep browser process alive while there are platform apps with background pages running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/usb/usb_apitest.cc

Issue 11117011: Keep browser process alive while there are platform apps with background pages running. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: And another test Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc ('k') | chrome/browser/extensions/extension_apitest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/usb/usb_apitest.cc

diff --git a/chrome/browser/extensions/api/usb/usb_apitest.cc b/chrome/browser/extensions/api/usb/usb_apitest.cc

index c7c382fb41e2ad5cf62aa04ca45dc13b4d82c49f..3729efad382118b20baf22597a60469c1769b384 100644

--- a/chrome/browser/extensions/api/usb/usb_apitest.cc

+++ b/chrome/browser/extensions/api/usb/usb_apitest.cc

@@ -81,7 +81,7 @@ class UsbApiTest : public ExtensionApiTest {

IN_PROC_BROWSER_TEST_F(UsbApiTest, DeviceHandling) {

EXPECT_CALL(*mock_device_, Close(_)).Times(1);

- ASSERT_TRUE(RunExtensionTest("usb/device_handling"));

+ ASSERT_TRUE(RunPlatformAppTest("usb/device_handling"));

}

IN_PROC_BROWSER_TEST_F(UsbApiTest, TransferEvent) {

@@ -99,14 +99,14 @@ IN_PROC_BROWSER_TEST_F(UsbApiTest, TransferEvent) {

IsochronousTransfer(UsbDevice::OUTBOUND, 3, _, 1, 1, 1, _, _))

.WillOnce(InvokeUsbTransferCallback<7>(USB_TRANSFER_COMPLETED));

EXPECT_CALL(*mock_device_, Close(_)).Times(AnyNumber());

- ASSERT_TRUE(RunExtensionTest("usb/transfer_event"));

+ ASSERT_TRUE(RunPlatformAppTest("usb/transfer_event"));

}

IN_PROC_BROWSER_TEST_F(UsbApiTest, ZeroLengthTransfer) {

EXPECT_CALL(*mock_device_, BulkTransfer(_, _, _, 0, _, _))

.WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_COMPLETED));

EXPECT_CALL(*mock_device_, Close(_)).Times(AnyNumber());

- ASSERT_TRUE(RunExtensionTest("usb/zero_length_transfer"));

+ ASSERT_TRUE(RunPlatformAppTest("usb/zero_length_transfer"));

}

IN_PROC_BROWSER_TEST_F(UsbApiTest, TransferFailure) {

@@ -115,5 +115,5 @@ IN_PROC_BROWSER_TEST_F(UsbApiTest, TransferFailure) {

.WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_ERROR))

.WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_TIMEOUT));

EXPECT_CALL(*mock_device_, Close(_)).Times(AnyNumber());

- ASSERT_TRUE(RunExtensionTest("usb/transfer_failure"));

+ ASSERT_TRUE(RunPlatformAppTest("usb/transfer_failure"));

}