chrome/browser/extensions/api/app_window/app_window_apitest.cc - Issue 11117011: Keep browser process alive while there are platform apps with background pages running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_window/app_window_apitest.cc

Issue 11117011: Keep browser process alive while there are platform apps with background pages running. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: And another test Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/external_filesystem_apitest.cc ('k') | chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/app_window/app_window_apitest.cc

diff --git a/chrome/browser/extensions/api/app_window/app_window_apitest.cc b/chrome/browser/extensions/api/app_window/app_window_apitest.cc

index 5307888e5a18ad7ee38169d85a1205315a5e293c..d514e4dd9ae973b850d6ec39926432bec2be7ef7 100644

--- a/chrome/browser/extensions/api/app_window/app_window_apitest.cc

+++ b/chrome/browser/extensions/api/app_window/app_window_apitest.cc

@@ -35,6 +35,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApiBounds) {

ready_listener.Reply(base::IntToString(slop));

ASSERT_TRUE(success_listener.WaitUntilSatisfied());

+ CloseShellWindowsAndWaitForAppToExit();

}

// TODO(asargent) - Fix onMinimzed event on OSX (crbug.com/162793) and figure

@@ -44,7 +46,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApiBounds) {

IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApiProperties) {

EXPECT_TRUE(

- RunExtensionTest("platform_apps/windows_api_properties")) << message_;

+ RunPlatformAppTest("platform_apps/windows_api_properties")) << message_;

}

#endif // defined(TOOLKIT_VIEWS)