chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc - Issue 11117011: Keep browser process alive while there are platform apps with background pages running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

Issue 11117011: Keep browser process alive while there are platform apps with background pages running. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Delegated Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_apitest.cc ('k') | chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc » ('j') | chrome/browser/extensions/extension_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

index f790b2605b93a868944988cde95bd6400e6d483c..73f35b4c21fe51e90a7363b6a92e0c0137a3c1d7 100644

--- a/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

@@ -132,17 +132,19 @@ IN_PROC_BROWSER_TEST_F(PlatformAppMediaGalleriesBrowserTest, NoGalleries) {

IN_PROC_BROWSER_TEST_F(PlatformAppMediaGalleriesBrowserTest,

MediaGalleriesRead) {

EnsureMediaDirectoriesExists media_directories;

- ASSERT_TRUE(RunPlatformAppTest("api_test/media_galleries/read_access"))

- << message_;

+ ASSERT_TRUE(RunPlatformAppTestReturnImmediately(

+ "api_test/media_galleries/read_access")) << message_;

RunSecondTestPhase(media_directories.num_galleries());

+ CloseShellWindowsAndWaitForAppToExit();

}

IN_PROC_BROWSER_TEST_F(PlatformAppMediaGalleriesBrowserTest,

MediaGalleriesNoAccess) {

EnsureMediaDirectoriesExists media_directories;

- ASSERT_TRUE(RunPlatformAppTest("api_test/media_galleries/no_access"))

- << message_;

+ ASSERT_TRUE(RunPlatformAppTestReturnImmediately(

+ "api_test/media_galleries/no_access")) << message_;

RunSecondTestPhase(media_directories.num_galleries());

+ CloseShellWindowsAndWaitForAppToExit();

}

IN_PROC_BROWSER_TEST_F(ExperimentalMediaGalleriesApiTest,