Helper functions in NetworkChangeNotifier related to WWAN use

net/base/network_change_notifier.h

Index: net/base/network_change_notifier.h
diff --git a/net/base/network_change_notifier.h b/net/base/network_change_notifier.h
index 731c305bebbf6279a0dd4e10d41488a3dbe4d3d4..892a97a1b4bfddbd5ac442cb45f5568bbd2583ff 100644
--- a/net/base/network_change_notifier.h
+++ b/net/base/network_change_notifier.h
@@ -130,9 +130,13 @@ class NET_EXPORT NetworkChangeNotifier {
   // |false| is inconclusive; even if some link is up, it is uncertain
   // whether a particular connection attempt to a particular remote site
   // will be successfully.
-  static bool IsOffline() {
-    return GetConnectionType() == CONNECTION_NONE;
-  }
+  static bool IsOffline();
+
+  // Returns true if the current connection is cellular.
+  static bool IsConnectionCellular();
+
+  // Returns true if |type| is a cellular connection.
+  static bool IsConnectionCellular(ConnectionType type);

[Ryan Sleevi, 2012/10/12 17:49:57]

Having two APIs to do something so functionally close seems less than ideal.
From a usability standpoint, it would be better to pick one idiom.

I suspect the preferred API is the IsConnectionCellcular(ConnectionType) form.


Additionally, I think comments similar to those on line 128-132 are important to
add here, to clarify how much faith callers should put in the return value. For
example, there's no guarantee that a "false" return means they aren't on
cellular - they could be tethered over wifi, for example.

 
   // Like Create(), but for use in tests.  The mock object doesn't monitor any
   // events, it merely rebroadcasts notifications when requested.