Helper functions in NetworkChangeNotifier related to WWAN use

net/base/network_change_notifier.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/network_change_notifier.h"
 
 #include "base/metrics/histogram.h"
 #include "base/synchronization/lock.h"
 #include "build/build_config.h"
 #include "googleurl/src/gurl.h"
@@ skipping 257 matching lines @@
 #if defined(OS_LINUX)
 // static
 const internal::AddressTrackerLinux*
 NetworkChangeNotifier::GetAddressTracker() {
   return g_network_change_notifier ?
         g_network_change_notifier->GetAddressTrackerInternal() : NULL;
 }
 #endif
 
 // static
+bool NetworkChangeNotifier::IsOffline() {
+   return GetConnectionType() == CONNECTION_NONE;
+}
+
+// static
+bool NetworkChangeNotifier::IsOverWWAN() {
+  return IsOverWWAN(GetConnectionType());
+}
+
+// static
+bool NetworkChangeNotifier::IsOverWWAN(ConnectionType type) {
+  return type >= CONNECTION_2G && type <= CONNECTION_4G;

[pauljensen, 2012/10/12 14:01:15]

I'd prefer a switch statement.  If you want to stick with using a range of
enumeration values its probably a good idea to add a comment at the enumeration
definition noting that anyone modifying the enumeration needs to understand
certain ranges have connotations.

+}
+
+// static
 NetworkChangeNotifier* NetworkChangeNotifier::CreateMock() {
   return new MockNetworkChangeNotifier();
 }
 
 void NetworkChangeNotifier::AddIPAddressObserver(IPAddressObserver* observer) {
   if (g_network_change_notifier)
     g_network_change_notifier->ip_address_observer_list_->AddObserver(observer);
 }
 
 void NetworkChangeNotifier::AddConnectionTypeObserver(
@@ skipping 94 matching lines @@
   DCHECK(g_network_change_notifier);
   g_network_change_notifier = NULL;
 }
 
 NetworkChangeNotifier::DisableForTest::~DisableForTest() {
   DCHECK(!g_network_change_notifier);
   g_network_change_notifier = network_change_notifier_;
 }
 
 }  // namespace net