Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2985)

Unified Diff: chrome/browser/google/google_url_tracker_infobar_delegate.h

Issue 11114009: Split the existing GoogleURLTrackerInfoBarDelegate into two classes (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google/google_url_tracker_infobar_delegate.h
===================================================================
--- chrome/browser/google/google_url_tracker_infobar_delegate.h (revision 161690)
+++ chrome/browser/google/google_url_tracker_infobar_delegate.h (working copy)
@@ -17,7 +17,7 @@
public:
GoogleURLTrackerInfoBarDelegate(InfoBarTabHelper* infobar_helper,
GoogleURLTracker* google_url_tracker,
- const GURL& new_google_url);
+ const GURL& search_url);
// ConfirmInfoBarDelegate:
virtual bool Accept() OVERRIDE;
@@ -27,27 +27,17 @@
virtual bool ShouldExpireInternal(
const content::LoadCommittedDetails& details) const OVERRIDE;
- // Allows GoogleURLTracker to change the Google base URL after the infobar has
- // been instantiated. This should only be called with an URL with the same
- // TLD as the existing one, so that the prompt we're displaying will still be
- // correct.
- void SetGoogleURL(const GURL& new_google_url);
-
- bool showing() const { return showing_; }
void set_pending_id(int pending_id) { pending_id_ = pending_id; }
// These are virtual so test code can override them in a subclass.
- virtual void Show(const GURL& search_url);
+ virtual void Update(const GURL& search_url);
virtual void Close(bool redo_search);
protected:
virtual ~GoogleURLTrackerInfoBarDelegate();
- InfoBarTabHelper* map_key_; // What |google_url_tracker_| uses to track us.
+ GoogleURLTracker* google_url_tracker_;
GURL search_url_;
- GoogleURLTracker* google_url_tracker_;
- GURL new_google_url_;
- bool showing_; // True if this delegate has been added to a TabContents.
int pending_id_;
Ilya Sherman 2012/10/16 20:16:24 nit: Class members should always have private visi
Peter Kasting 2012/10/16 23:29:35 Done.
private:

Powered by Google App Engine
This is Rietveld 408576698