Add DownloadControllerAndroid public interface for android.

android_webview/native/aw_web_contents_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/aw_web_contents_delegate.h"
 
 #include "base/lazy_instance.h"
 #include "android_webview/browser/find_helper.h"
 #include "android_webview/native/aw_contents.h"
 #include "android_webview/native/aw_javascript_dialog_creator.h"
+#include "content/public/browser/android/download_controller_android.h"
+#include "content/public/browser/download_item.h"

[joth, 2012/10/12 20:50:03]

nit: forward declare DownloadItem rather than #include.

[nilesh, 2012/10/12 21:07:45]

Done.

 #include "content/public/browser/web_contents.h"
+#include "net/http/http_request_headers.h"
 
 using content::WebContents;
 
 namespace android_webview {
 
 static base::LazyInstance<AwJavaScriptDialogCreator>::Leaky
     g_javascript_dialog_creator = LAZY_INSTANCE_INITIALIZER;
 
 AwWebContentsDelegate::AwWebContentsDelegate(
     JNIEnv* env,
@@ skipping 18 matching lines @@
   AwContents* aw_contents = AwContents::FromWebContents(web_contents);
   if (!aw_contents)
     return;
 
   aw_contents->GetFindHelper()->HandleFindReply(request_id,
                                                 number_of_matches,
                                                 active_match_ordinal,
                                                 final_update);
 }
 
+bool AwWebContentsDelegate::CanDownload(content::RenderViewHost* source,
+                                        int request_id,
+                                        const std::string& request_method) {
+  if (request_method == net::HttpRequestHeaders::kGetMethod) {
+    content::DownloadControllerAndroid::Get()->CreateGETDownload(
+        source, request_id);
+    return false;
+  }
+  return true;

[joth, 2012/10/12 20:50:03]

always return false here, as we (currently) never want to have the chrome stack
deal with the download.

[nilesh, 2012/10/12 21:07:45]

Done.

[nilesh, 2012/10/12 21:31:19]

I think you meant return false always, but still handle GET downloads. Fixing.

+}
+
+void AwWebContentsDelegate::OnStartDownload(WebContents* source,
+                                            content::DownloadItem* download) {
+  content::DownloadControllerAndroid::Get()->OnPostDownloadStarted(
+      source, download);

[joth, 2012/10/12 20:50:03]

replace this with
NOTREACHED();  // We always return false in CanDownload.

[nilesh, 2012/10/12 21:07:45]

Done.

+}
+
 }  // namespace android_webview