Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 11112011: Fix hyphen-locale.html and hyphenate-limit-lines.html. (Closed)

Created:
8 years, 2 months ago by Hironori Bono
Modified:
8 years, 2 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix hyphen-locale.html and hyphenate-limit-lines.html. Even though I have implemented hyphenation for DumpRenderTree, a couple of layout tests still fail on Chromium DumpRenderTree due to the following reasons: * hyphen-locale.html uses "en" and "en_GB" for the hyphenation locale, and; * hyphenate-limit-lines.html uses capitalized words. To fix these tests, this change supports these locales and capitalized words. BUG=140490 TEST=hyphen-locale.html and hyphenate-limit-lines.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M webkit/support/test_webkit_platform_support.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hironori Bono
8 years, 2 months ago (2012-10-12 08:53:42 UTC) #1
tony
LGTM
8 years, 2 months ago (2012-10-12 17:16:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/11112011/1
8 years, 2 months ago (2012-10-15 02:29:11 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 04:38:20 UTC) #4
Change committed as 161825

Powered by Google App Engine
This is Rietveld 408576698