ui/gfx/screen_mac.mm - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/screen_mac.mm

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/screen_mac.mm

diff --git a/ui/gfx/screen_mac.mm b/ui/gfx/screen_mac.mm

index 325c679209d52523ba4d7927768e52384a6d2e13..79911a3294176c45158238e5df4c479ea7b1b0d0 100644

--- a/ui/gfx/screen_mac.mm

+++ b/ui/gfx/screen_mac.mm

@@ -39,7 +39,8 @@ NSScreen* GetMatchingScreen(const gfx::Rect& match_rect) {

for (NSScreen* screen in [NSScreen screens]) {

gfx::Rect monitor_area = ConvertCoordinateSystem([screen frame]);

- gfx::Rect intersection = monitor_area.Intersect(match_rect);

+ gfx::Rect intersection = monitor_area;

+ intersection.Intersect(match_rect);

int area = intersection.width() * intersection.height();

if (area > max_area) {

max_area = area;

« ui/gfx/rect_f.h ('K') | « ui/gfx/screen_gtk.cc ('k') | ui/views/view.cc » ('j') | no next file with comments »