ppapi/examples/ime/ime.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/examples/ime/ime.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/examples/ime/ime.cc

diff --git a/ppapi/examples/ime/ime.cc b/ppapi/examples/ime/ime.cc

index e217145d399bcd7ed01d0dcdec7a393fef0d9c1d..983053268c89e0009de29c83cf52ae45cb7b9aca 100644

--- a/ppapi/examples/ime/ime.cc

+++ b/ppapi/examples/ime/ime.cc

@@ -148,7 +148,7 @@ class MyTextField {

// Paint on the specified ImageData.

void PaintOn(pp::ImageData* image, pp::Rect clip) {

- clip = clip.Intersect(area_);

+ clip.Intersect(area_);

FillRect(image, clip, kTextfieldBgColor);

if (caret_pos_ != std::string::npos) {

« no previous file with comments | « content/renderer/webplugin_delegate_proxy.cc ('k') | ppapi/utility/graphics/paint_aggregator.cc » ('j') | ui/gfx/rect_base.h » ('J')