content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_gtk.cc ('k') | content/browser/renderer_host/render_widget_host_view_win.cc » ('j') | ui/gfx/rect_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 00e46429c5addafcc61ecee4fc5b74f35bcda59e..b0699d75510e9ab5bbcca6d8293594166c2a049b 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -2272,7 +2272,8 @@ void RenderWidgetHostViewMac::SetTextInputActive(bool active) {

// smaller and the renderer hasn't yet repainted.

int yOffset = NSHeight([self bounds]) - backingStore->size().height();

- gfx::Rect paintRect = bitmapRect.Intersect(damagedRect);

+ gfx::Rect paintRect = bitmapRect;

+ paintRect.Intersect(damagedRect);

if (!paintRect.IsEmpty()) {

// if we have a CGLayer, draw that into the window

if (backingStore->cg_layer()) {