chrome/browser/notifications/balloon_collection_impl.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/balloon_collection_impl.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/balloon_collection_impl.cc

diff --git a/chrome/browser/notifications/balloon_collection_impl.cc b/chrome/browser/notifications/balloon_collection_impl.cc

index 1f4435ae74bae3bbcd9d590984d020a731918943..ab5d3e96d2bab186f4abf679a3af65f376242a9a 100644

--- a/chrome/browser/notifications/balloon_collection_impl.cc

+++ b/chrome/browser/notifications/balloon_collection_impl.cc

@@ -218,7 +218,7 @@ gfx::Rect BalloonCollectionImpl::GetBalloonsBoundingBox() const {

for (iter = balloons.begin(); iter != balloons.end(); ++iter) {

gfx::Rect balloon_box = gfx::Rect((*iter)->GetPosition(),

(*iter)->GetViewSize());

- bounds = bounds.Union(balloon_box);

+ bounds.Union(balloon_box);

}

return bounds;

« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/ui/gtk/browser_toolbar_gtk.cc » ('j') | ui/gfx/rect_base.h » ('J')