Allow null buffer resources to be returned through the PPB_ContentDecryptor_Private proxy.

webkit/media/crypto/proxy_decryptor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/media/crypto/proxy_decryptor.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 152 matching lines @@
   pending_buffer_to_decrypt_ = encrypted;
   pending_decrypt_cb_ = decrypt_cb;
 
   // This is safe as we do not replace/delete an existing decryptor at run-time.
   media::Decryptor* decryptor = NULL;
   {
     base::AutoLock auto_lock(lock_);
     decryptor = decryptor_.get();
   }
   if (!decryptor) {
-    DVLOG(1) << "ProxyDecryptor::Decrypt(): decryptor not initialized.";
+    DVLOG(1) << "Decrypt(): decryptor not initialized.";
 
     // TODO(xhwang): The same NeedKey may be fired here and multiple times in
     // OnBufferDecrypted(). While the spec says only one NeedKey should be
     // fired. Leave them as is since the spec about this may change.
     FireNeedKey(client_, encrypted);
     return;
   }
 
   DecryptPendingBuffer();
 }
 
 void ProxyDecryptor::CancelDecrypt() {
+  DVLOG(1) << "CancelDecrypt()";

[xhwang, 2012/10/12 00:06:44]

why this is level one?

[ddorwin, 2012/10/12 00:21:16]

Because it is rarer and much more interesting than every block (see below).

   DCHECK(decryption_message_loop_->BelongsToCurrentThread());
 
   if (!pending_buffer_to_decrypt_) {
     DCHECK(pending_decrypt_cb_.is_null());
     DCHECK(!is_waiting_for_decryptor_);
     return;
   }
 
   DecryptCB decrypt_cb;
   if (!is_waiting_for_decryptor_) {
@@ skipping 78 matching lines @@
 
   if (is_waiting_for_decryptor_) {
     has_new_key_added_ = true;
     return;
   }
 
   DecryptPendingBuffer();
 }
 
 void ProxyDecryptor::DecryptPendingBuffer() {
+  DVLOG(3) << "DecryptPendingBuffer()";
   DCHECK(decryption_message_loop_->BelongsToCurrentThread());
   DCHECK(pending_buffer_to_decrypt_);
   DCHECK(!is_waiting_for_decryptor_);
 
   is_waiting_for_decryptor_ = true;
   decryptor_->Decrypt(
       pending_buffer_to_decrypt_,
       base::Bind(&ProxyDecryptor::OnBufferDecrypted, base::Unretained(this)));
 }
 
 void ProxyDecryptor::OnBufferDecrypted(
     media::Decryptor::Status status,
     const scoped_refptr<media::DecoderBuffer>& decrypted) {
   if (!decryption_message_loop_->BelongsToCurrentThread()) {
     decryption_message_loop_->PostTask(FROM_HERE, base::Bind(
         &ProxyDecryptor::OnBufferDecrypted, base::Unretained(this),
         status, decrypted));
     return;
   }
 
+  DVLOG(2) << "OnBufferDecrypted()";

[xhwang, 2012/10/12 00:06:44]

why this is level 2?

[ddorwin, 2012/10/12 00:21:16]

So we can get level 1 logging without getting spammed for every block.

   DCHECK(pending_buffer_to_decrypt_);
   DCHECK(!pending_decrypt_cb_.is_null());
   DCHECK(is_waiting_for_decryptor_);
 
   is_waiting_for_decryptor_ = false;
   bool need_to_try_again_if_nokey_is_returned = has_new_key_added_;
   has_new_key_added_ = false;
 
   if (is_canceling_decrypt_) {
     pending_buffer_to_decrypt_ = NULL;
@@ skipping 16 matching lines @@
     return;
   }
 
   // TODO(xhwang): The same NeedKey may be fired multiple times here and also
   // in Decrypt(). While the spec says only one NeedKey should be fired. Leave
   // them as is since the spec about this may change.
   FireNeedKey(client_, pending_buffer_to_decrypt_);
 }
 
 }  // namespace webkit_media