Logging: pass logging related cmd line options to utility process

content/browser/utility_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/utility_process_host_impl.h"
 
+#include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/browser_child_process_host_impl.h"
 #include "content/common/child_process_host_impl.h"
 #include "content/common/utility_messages.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/utility_process_host_client.h"
@@ skipping 141 matching lines @@
   if (has_cmd_prefix) {
     // launch the utility child process with some prefix (usually "xterm -e gdb
     // --args").
     cmd_line->PrependWrapper(browser_command_line.GetSwitchValueNative(
         switches::kUtilityCmdPrefix));
   }
 
   cmd_line->AppendSwitchPath(switches::kUtilityProcessAllowedDir, exposed_dir_);
 #endif
 
+  static const char* kForwardSwitches[] = {
+    switches::kEnableLogging,  // Support, e.g., --enable-logging=stderr

[piman, 2012/10/12 17:00:33]

nit: I don't think this comment adds anything. Please remove?

+    switches::kV,
+    switches::kVModule,
+  };

[piman, 2012/10/12 17:00:33]

Could you move the flags handling above into here, when it's of the type if
(browser_command_line.HasSwitch(kFlag)) cmd_line->AppendSwitch(kFlag);
It's the same thing, but this way is more concise/readable.

+  cmd_line->CopySwitchesFrom(browser_command_line, kForwardSwitches,
+                             arraysize(kForwardSwitches));
+
   bool use_zygote = false;
 
 #if defined(OS_LINUX)
   use_zygote = !no_sandbox_ && use_linux_zygote_;
 #endif
 
   process_->Launch(
 #if defined(OS_WIN)
       exposed_dir_,
 #elif defined(OS_POSIX)
@@ skipping 13 matching lines @@
           message));
   return true;
 }
 
 void UtilityProcessHostImpl::OnProcessCrashed(int exit_code) {
   BrowserThread::PostTask(
       client_thread_id_, FROM_HERE,
       base::Bind(&UtilityProcessHostClient::OnProcessCrashed, client_.get(),
             exit_code));
 }