Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 11103008: Chrome should never attempt to launch in Metro if it is no longer default browser (Closed)

Created:
8 years, 2 months ago by gab
Modified:
8 years, 2 months ago
CC:
chromium-reviews, chrome-win8-eng_google.com
Visibility:
Public.

Description

Chrome should never attempt to launch in Metro if it is no longer default browser BUG=155079 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161698

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase on r161286 #

Patch Set 3 : remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/process_singleton_win.cc View 1 2 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gab
8 years, 2 months ago (2012-10-10 17:44:26 UTC) #1
grt (UTC plus 2)
lgtm. i wish this was possible without adding more I/O to the startup path. http://codereview.chromium.org/11103008/diff/1/chrome/browser/process_singleton_win.cc ...
8 years, 2 months ago (2012-10-11 03:26:06 UTC) #2
gab
Thanks, +brettw for OWNER, feel free to CQ. Gab http://codereview.chromium.org/11103008/diff/1/chrome/browser/process_singleton_win.cc File chrome/browser/process_singleton_win.cc (right): http://codereview.chromium.org/11103008/diff/1/chrome/browser/process_singleton_win.cc#newcode262 chrome/browser/process_singleton_win.cc:262: ...
8 years, 2 months ago (2012-10-11 03:57:08 UTC) #3
gab
@brettw: ping
8 years, 2 months ago (2012-10-12 03:00:19 UTC) #4
brettw
lgtm rubberstamp
8 years, 2 months ago (2012-10-12 17:50:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/11103008/1002
8 years, 2 months ago (2012-10-12 17:52:21 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-13 02:27:13 UTC) #7
Change committed as 161698

Powered by Google App Engine
This is Rietveld 408576698