Issue 11103008: Chrome should never attempt to launch in Metro if it is no longer default browser

Issue 11103008: Chrome should never attempt to launch in Metro if it is no longer default browser (Closed)

Created:
8 years, 2 months ago by gab

Modified:
8 years, 2 months ago

Reviewers:
brettw, grt (UTC plus 2)

CC:
chromium-reviews, chrome-win8-eng_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Chrome should never attempt to launch in Metro if it is no longer default browser BUG=155079 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161698

Patch Set 2 : Rebase on r161286 #

Patch Set 3 : remove unused variable #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/browser/process_singleton_win.cc	View	1 2	4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

grt (UTC plus 2)

lgtm. i wish this was possible without adding more I/O to the startup path. http://codereview.chromium.org/11103008/diff/1/chrome/browser/process_singleton_win.cc ...

8 years, 2 months ago (2012-10-11 03:26:06 UTC) #2

gab

Thanks, +brettw for OWNER, feel free to CQ. Gab http://codereview.chromium.org/11103008/diff/1/chrome/browser/process_singleton_win.cc File chrome/browser/process_singleton_win.cc (right): http://codereview.chromium.org/11103008/diff/1/chrome/browser/process_singleton_win.cc#newcode262 chrome/browser/process_singleton_win.cc:262: ...

8 years, 2 months ago (2012-10-11 03:57:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/11103008/1002

8 years, 2 months ago (2012-10-12 17:52:21 UTC) #6

Change committed as 161698

Expand Messages | Collapse Messages