Issue 1110014: Reland r42300: "HttpRequestHeaders refactor.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110014: Reland r42300: "HttpRequestHeaders refactor."" (Closed)

Created:
10 years, 9 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews

Visibility:
Public.

Description

Reland r42300: "HttpRequestHeaders refactor."" This time, make sure HttpRequestHeaders::FindHeader() checks key lengths are equal. * Create HttpRequestHeaders. * Switch HttpNetworkTransaction to build request headers. TODO: Change extra_headers to use HttpRequestHeaders. BUG=22588 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42376

Patch Set 1 #

Total comments: 3

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+592 lines, -69 lines)			Patch
M	base/string_util.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	base/string_util.cc	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	base/string_util_unittest.cc	View	2 chunks	+49 lines, -1 line	0 comments	Download
M	net/http/http_network_transaction.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View	6 chunks	+80 lines, -63 lines	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	net/http/http_request_headers.h	View	1 chunk	+97 lines, -0 lines	0 comments	Download
A	net/http/http_request_headers.cc	View	1 chunk	+134 lines, -0 lines	1 comment	Download
A	net/http/http_request_headers_unittest.cc	View	1 chunk	+127 lines, -0 lines	2 comments	Download
M	net/net.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

http://codereview.chromium.org/1110014/diff/1/8 File net/http/http_request_headers.cc (right): http://codereview.chromium.org/1110014/diff/1/8#newcode126 net/http/http_request_headers.cc:126: if (key.length() == it->key.length() && This is the 1 ...

10 years, 9 months ago (2010-03-23 04:25:56 UTC) #1

eroman

10 years, 9 months ago (2010-03-23 04:47:51 UTC) #2

lgtm

http://codereview.chromium.org/1110014/diff/1/10
File net/http/http_request_headers_unittest.cc (right):

http://codereview.chromium.org/1110014/diff/1/10#newcode52
net/http/http_request_headers_unittest.cc:52: EXPECT_EQ("FooBar: smokes\r\nFoo:
crack\r\n\r\n", headers.ToString());
hah!

Expand Messages | Collapse Messages