Issue 1110012: Revert r42300: "HttpRequestHeaders refactor."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110012: Revert r42300: "HttpRequestHeaders refactor." (Closed)

Created:
10 years, 9 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews

Visibility:
Public.

Revert r42300: "HttpRequestHeaders refactor." Broke access-control-basic-whitelist-request-headers.html layout test. BUG=22588 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42305

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -584 lines)			Patch
M	base/string_util.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	base/string_util.cc	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	base/string_util_unittest.cc	View	2 chunks	+1 line, -49 lines	0 comments	Download
M	net/http/http_network_transaction.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View	6 chunks	+63 lines, -80 lines	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	net/http/http_request_headers.h	View	1 chunk	+0 lines, -97 lines	0 comments	Download
D	net/http/http_request_headers.cc	View	1 chunk	+0 lines, -133 lines	0 comments	Download
D	net/http/http_request_headers_unittest.cc	View	1 chunk	+0 lines, -120 lines	0 comments	Download
M	net/net.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

rubber stamp LGTM