Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 111001: Added context information to scripts (Closed)

Created:
11 years, 7 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added context information to scripts. Added a simple initial version of a context mirror object which just holds the user data from the context, and does not preserve handle identity. A script object now holds a reference to the custom data from the context it was compiled in. This data is included in the debugger protocol for scripts. Changed the serialization for the scripts command to use the mirror objects instaed of custom serialization. This included passing options from the debugger request to the serializer for including the full source of scripts in the response. Committed: http://code.google.com/p/v8/source/detail?r=1877

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -26 lines) Patch
M src/accessors.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/accessors.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/debug-delay.js View 4 chunks +11 lines, -20 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mirror-delay.js View 10 chunks +70 lines, -5 lines 2 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Thygesen Gjesse
I was trying to just reference the context from the script, but that leaked global ...
11 years, 7 months ago (2009-05-05 14:59:10 UTC) #1
yurys
LGTM, though having a reference from the script object to the context and requesting data ...
11 years, 7 months ago (2009-05-06 07:22:34 UTC) #2
yurys
11 years, 7 months ago (2009-05-06 07:22:44 UTC) #3
Søren Thygesen Gjesse
Having a reference from the script to the context should be possible, however just adding ...
11 years, 7 months ago (2009-05-06 07:48:54 UTC) #4
Christian Plesner Hansen
11 years, 7 months ago (2009-05-06 08:29:21 UTC) #5
Lgtm!

Powered by Google App Engine
This is Rietveld 408576698