Browser Plugin: Enable File Chooser (<input type="file">)

content/browser/browser_plugin/browser_plugin_embedder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 
 #include <set>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 77 matching lines @@
 
   const std::string& host =
       render_view_host->GetSiteInstance()->GetSiteURL().host();
   guest_web_contents = WebContentsImpl::CreateGuest(
       web_contents()->GetBrowserContext(),
       host,
       instance_id);
 
   guest = guest_web_contents->GetBrowserPluginGuest();
   guest->set_embedder_render_process_host(render_view_host->GetProcess());
-
+  guest->set_embedder_web_contents(web_contents());

[Charlie Reis, 2012/10/16 21:07:21]

Do we really want to set so many fields on the guest (RenderProcessHost,
WebContents, RenderViewHost from Sadrul's CL)?  I worry about them getting out
of sync in the future.

Seems like we only need to set the WebContents, since you can call
GetRenderViewHost() and GetRenderProcessHost() on the WebContents.  Less room
for error.

[Fady Samuel, 2012/10/17 00:28:06]

Done.

   RendererPreferences* guest_renderer_prefs =
       guest_web_contents->GetMutableRendererPrefs();
   // Copy renderer preferences (and nothing else) from the embedder's
   // TabContents to the guest.
   //
   // For GTK and Aura this is necessary to get proper renderer configuration
   // values for caret blinking interval, colors related to selection and
   // focus.
   *guest_renderer_prefs = *web_contents()->GetMutableRendererPrefs();
 
@@ skipping 195 matching lines @@
       bool visible = *Details<bool>(details).ptr();
       WebContentsVisibilityChanged(visible);
       break;
     }
     default:
       NOTREACHED() << "Unexpected notification type: " << type;
   }
 }
 
 }  // namespace content