media/audio/audio_io.h - Issue 11098031: Get PulseAudio implementation working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_io.h

Issue 11098031: Get PulseAudio implementation working. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cork. BeginWrite. Cleanup. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/audio_io.h

diff --git a/media/audio/audio_io.h b/media/audio/audio_io.h

index bdc9f6fa6b71d25ba03895ee7958f0fef8028747..cfc71bdb4681dedecad48f483c83a52973d892b6 100644

--- a/media/audio/audio_io.h

+++ b/media/audio/audio_io.h

@@ -90,7 +90,8 @@ class MEDIA_EXPORT AudioOutputStream {

virtual ~AudioOutputStream() {}

- // Open the stream. false is returned if the stream cannot be opened.

+ // Open the stream. false is returned if the stream cannot be opened. Open()

+ // must always be followed by a call to Close() even if Open() fails.

scherkus (not reviewing) 2012/10/11 20:19:31 this makes me sad considering we return true/false

DaleCurtis 2012/10/12 00:09:12 Yeah, it's not ideal. At least the comment codifi

virtual bool Open() = 0;

// Starts playing audio and generating AudioSourceCallback::OnMoreData().

« no previous file with comments | « no previous file | media/audio/pulse/pulse_output.h » ('j') | media/audio/pulse/pulse_output.h » ('J')