Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5435)

Unified Diff: chrome/browser/sessions/session_types.cc

Issue 11098002: [Sync] Add a new global_id field to sync_pb::TabNavigation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't remove unique_id Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sessions/session_types_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_types.cc
diff --git a/chrome/browser/sessions/session_types.cc b/chrome/browser/sessions/session_types.cc
index 183b3a90d54ad386be8772babc83af166e5080c3..f89af4f1f418afef2ff1defde6ee0d83697d948f 100644
--- a/chrome/browser/sessions/session_types.cc
+++ b/chrome/browser/sessions/session_types.cc
@@ -414,9 +414,9 @@ sync_pb::TabNavigation TabNavigation::ToSyncData() const {
(transition_type_ & content::PAGE_TRANSITION_CHAIN_END) != 0);
sync_data.set_unique_id(unique_id_);
- // TODO(akalin): Don't lose resolution, i.e. define a new timestamp
- // field with microsecond resolution and use that.
sync_data.set_timestamp(syncer::TimeToProtoTime(timestamp_));
+ // The full-resolution timestamp works as a global ID.
+ sync_data.set_global_id(timestamp_.ToInternalValue());
return sync_data;
}
« no previous file with comments | « no previous file | chrome/browser/sessions/session_types_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698