ui/gfx/safe_integer_conversions.h - Issue 11093031: Add gfx::ToRoundedInt safe conversion method from float to int.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/safe_integer_conversions.h

Issue 11093031: Add gfx::ToRoundedInt safe conversion method from float to int. (Closed) Base URL: http://git.chromium.org/chromium/src.git@gfx-scale

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_GFX_SAFE_FLOOR_CEIL_H_	5 #ifndef UI_GFX_SAFE_INTEGER_CONVERSIONS_H_

6 #define UI_GFX_SAFE_FLOOR_CEIL_H_	6 #define UI_GFX_SAFE_INTEGER_CONVERSIONS_H_

7	7

8 namespace gfx {	8 namespace gfx {

9	9

10 UI_EXPORT int ClampToInt(float value);	10 UI_EXPORT int ClampToInt(float value);
	tfarina 2012/10/10 00:29:44 is it worth adding unittests for these functions? is it worth adding unittests for these functions? tfarina 2012/10/10 00:29:44 missing the include to ui/base/ui_export.h missing the include to ui/base/ui_export.h danakj 2012/10/10 00:31:35 Done. Show quoted text On 2012/10/10 00:29:44, tfarina wrote: > missing the include to ui/base/ui_export.h Done. danakj 2012/10/10 00:31:35 I think the likelihood these functions will regres Show quoted text On 2012/10/10 00:29:44, tfarina wrote: > is it worth adding unittests for these functions? I think the likelihood these functions will regress is marginal.
11 UI_EXPORT int ToFlooredInt(float value);	11 UI_EXPORT int ToFlooredInt(float value);

12 UI_EXPORT int ToCeiledInt(float value);	12 UI_EXPORT int ToCeiledInt(float value);

	13 UI_EXPORT int ToRoundedInt(float value);

13	14

14 } // namespace gfx	15 } // namespace gfx

15	16

16 #endif // UI_GFX_SAFE_FLOOR_CEIL_H_	17 #endif // UI_GFX_SAFE_INTEGER_CONVERSIONS_H_

OLD	NEW

« no previous file with comments | « ui/gfx/safe_floor_ceil.cc ('k') | ui/gfx/safe_integer_conversions.cc » ('j') | no next file with comments »