chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js - Issue 11092078: Add some error messages for setting wallpaper failures on Chrome(c++) side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js

Issue 11092078: Add some error messages for setting wallpaper failures on Chrome(c++) side. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: nits Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/extensions/wallpaper_private_api.cc ('K') | « chrome/browser/chromeos/extensions/wallpaper_private_api.cc ('k') | chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js

diff --git a/chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js b/chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js

index fc762d59ab3d5884f606d142b437f73d67ddab52..bfd0c735c54c2f108feee5b206c8f104f4417f21 100644

--- a/chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js

+++ b/chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js

@@ -258,7 +258,9 @@ ButterBar.prototype.onDownloadAbort_ = function(e) {

* @param {Event} e A load ProgressEvent from XMLHttpRequest.

ButterBar.prototype.onDownloadComplete_ = function(e) {

- this.hide_();

+ var options = {progress: 100, actions: {}, timeout: 0};

+ var progressString = 'Loading';

Nikita (slow) 2012/10/15 15:14:11 String should be localized.

bshe 2012/10/17 00:13:51 Pre discussion with kuscher, we just want to show

+ this.show(progressString, options);

this.xhr_ = null;

};