chrome/browser/task_manager/task_manager_resource_providers.cc - Issue 11092066: [Panels] Fix favicon crash from using deleted WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_resource_providers.cc

Issue 11092066: [Panels] Fix favicon crash from using deleted WebContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix NoticePanelChanges test Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/task_manager/task_manager_resource_providers.cc

diff --git a/chrome/browser/task_manager/task_manager_resource_providers.cc b/chrome/browser/task_manager/task_manager_resource_providers.cc

index 0639ff413213e501af2485b7ec8ba4ecfdcfc604..57faee026eea30d3e4f4f7e97678445ef927affc 100644

--- a/chrome/browser/task_manager/task_manager_resource_providers.cc

+++ b/chrome/browser/task_manager/task_manager_resource_providers.cc

@@ -706,7 +706,7 @@ void TaskManagerPanelResourceProvider::Observe(int type,

for (PanelResourceMap::iterator iter = resources_.begin();

iter != resources_.end(); ++iter) {

Panel* panel = iter->first;

- if (panel->GetWebContents() == web_contents) {

+ if (!panel->GetWebContents()) {

Remove(panel);

break;

}