Browser Plugin: Implement CanGoBack/CanGoForward

content/browser/browser_plugin/browser_plugin_host_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/singleton.h"
 #include "base/run_loop.h"
 #include "base/test/test_timeouts.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/browser_plugin/browser_plugin_host_factory.h"
@@ skipping 525 matching lines @@
   // Go back and verify that we're back at P2.
   {
     const string16 expected_title = ASCIIToUTF16("P2");
     content::TitleWatcher title_watcher(test_guest()->web_contents(),
                                         expected_title);
 
     rvh->ExecuteJavascriptAndGetValue(string16(), ASCIIToUTF16("Back();"));
 
     string16 actual_title = title_watcher.WaitAndGetTitle();
     EXPECT_EQ(expected_title, actual_title);
+
+    base::Value* value =
+        rvh->ExecuteJavascriptAndGetValue(string16(),
+                                          ASCIIToUTF16("CanGoBack()"));
+    bool result = false;
+    ASSERT_TRUE(value->GetAsBoolean(&result));
+    EXPECT_TRUE(result);
+
+    value = rvh->ExecuteJavascriptAndGetValue(string16(),
+                                              ASCIIToUTF16("CanGoForward()"));
+    result = false;
+    ASSERT_TRUE(value->GetAsBoolean(&result));
+    EXPECT_TRUE(result);
   }
 
   // Go forward and verify that we're back at P3.
   {
     const string16 expected_title = ASCIIToUTF16("P3");
     content::TitleWatcher title_watcher(test_guest()->web_contents(),
                                         expected_title);
 
+    base::Value* value =
+        rvh->ExecuteJavascriptAndGetValue(string16(),
+                                          ASCIIToUTF16("CanGoForward()"));
+    bool result = false;
+    ASSERT_TRUE(value->GetAsBoolean(&result));
+    EXPECT_TRUE(result);

[Charlie Reis, 2012/10/11 19:03:01]

Please move this after the Forward() call and have it EXPECT_FALSE instead.  (We
just checked if it was true above on line 558.)

     rvh->ExecuteJavascriptAndGetValue(string16(), ASCIIToUTF16("Forward();"));
 
     string16 actual_title = title_watcher.WaitAndGetTitle();
     EXPECT_EQ(expected_title, actual_title);
   }
 
   // Go back two entries and verify that we're back at P1.
   {
     const string16 expected_title = ASCIIToUTF16("P1");
     content::TitleWatcher title_watcher(test_guest()->web_contents(),
                                         expected_title);
 
     rvh->ExecuteJavascriptAndGetValue(string16(), ASCIIToUTF16("Go(-2);"));
 
     string16 actual_title = title_watcher.WaitAndGetTitle();
     EXPECT_EQ(expected_title, actual_title);
+
+    base::Value* value =
+        rvh->ExecuteJavascriptAndGetValue(string16(),
+                                          ASCIIToUTF16("CanGoBack()"));
+    bool result = true;
+    ASSERT_TRUE(value->GetAsBoolean(&result));
+    EXPECT_FALSE(result);
   }
 }
 
 // This tests verifies that reloading the embedder does not crash the browser
 // and that the guest is reset.
 IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, ReloadEmbedder) {
   const char* kEmbedderURL = "files/browser_plugin_embedder.html";
   StartBrowserPluginTest(kEmbedderURL, kHTMLForGuest, true, "");
   RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(
       test_embedder()->web_contents()->GetRenderViewHost());
@@ skipping 116 matching lines @@
   EXPECT_TRUE(v->GetAsString(&result));
   EXPECT_EQ(redirect_url.spec().c_str(), result);
 
   v = rvh->ExecuteJavascriptAndGetValue(
       string16(), ASCIIToUTF16("redirectNewUrl"));
   EXPECT_TRUE(v->GetAsString(&result));
   EXPECT_EQ(test_server()->GetURL("files/title1.html").spec().c_str(), result);
 }
 
 }  // namespace content