Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: sync/engine/process_updates_command.h

Issue 11091009: sync: Merge {Verify,Process}UpdatesCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor fixes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/engine/process_updates_command.cc » ('j') | sync/engine/process_updates_command.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/process_updates_command.h
diff --git a/sync/engine/process_updates_command.h b/sync/engine/process_updates_command.h
index 7604d11535e6dc0b2507419fffdcdebc0bc38f34..9f89a63537755a01ae1599a69573a19bf6a3ac7d 100644
--- a/sync/engine/process_updates_command.h
+++ b/sync/engine/process_updates_command.h
@@ -21,14 +21,12 @@ class WriteTransaction;
class Cryptographer;
-// A syncer command for processing updates.
+// A syncer command for verifying and processing updates.
//
-// Preconditions - updates in the SyncerSesssion have been downloaded
-// and verified.
+// Preconditions - Updates in the SyncerSesssion have been downloaded.
//
// Postconditions - All of the verified SyncEntity data will be copied to
// the server fields of the corresponding syncable entries.
-// TODO(tim): This should not be ModelChanging (bug 36592).
class ProcessUpdatesCommand : public ModelChangingSyncerCommand {
public:
ProcessUpdatesCommand();
@@ -42,6 +40,11 @@ class ProcessUpdatesCommand : public ModelChangingSyncerCommand {
sessions::SyncSession* session) OVERRIDE;
private:
+ VerifyResult VerifyUpdate(
+ syncable::WriteTransaction* trans,
+ const sync_pb::SyncEntity& entry,
+ ModelTypeSet requested_types,
+ const ModelSafeRoutingInfo& routes);
ServerUpdateProcessingResult ProcessUpdate(
const sync_pb::SyncEntity& proto_update,
const Cryptographer* cryptographer,
« no previous file with comments | « no previous file | sync/engine/process_updates_command.cc » ('j') | sync/engine/process_updates_command.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698