Update PluginInstance for decrypt-and-decode video.

webkit/plugins/ppapi/ppapi_plugin_instance.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 #define WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 245 matching lines @@
   // TODO(tomfinegan): Move decryptor methods to delegate class.
   void set_decrypt_client(media::DecryptorClient* client);
   bool GenerateKeyRequest(const std::string& key_system,
                           const std::string& init_data);
   bool AddKey(const std::string& session_id,
               const std::string& key,
               const std::string& init_data);
   bool CancelKeyRequest(const std::string& session_id);
   bool Decrypt(const scoped_refptr<media::DecoderBuffer>& encrypted_buffer,
                const media::Decryptor::DecryptCB& decrypt_cb);
-  // TODO(xhwang): Change DecryptCB to a DecoderInitCB.
   bool InitializeVideoDecoder(
       const media::VideoDecoderConfig& decoder_config,
-      const media::Decryptor::DecryptCB& decrypt_cb);
+      const media::Decryptor::DecoderInitCB& decoder_init_cb);
   // TODO(tomfinegan): Add callback args for DeinitializeDecoder() and
   // ResetDecoder()
   bool DeinitializeDecoder();
   bool ResetDecoder();
-  // TODO(xhwang): Update this when we need to support decrypt and decode.
-  // Note: This method can be used with an unencrypted frame.
   bool DecryptAndDecode(

[ddorwin, 2012/10/13 01:40:28]

"// Note: This method can be used with an unencrypted frame." was removed.

[xhwang, 2012/10/15 19:53:01]

Done.

       const scoped_refptr<media::DecoderBuffer>& encrypted_buffer,
-      const media::Decryptor::DecryptCB& decrypt_cb);
+      const media::Decryptor::VideoDecodeCB& video_decode_cb);

[ddorwin, 2012/10/13 01:40:28]

What's the plan for audio? Will we have two CBs or rename it?

[xhwang, 2012/10/15 19:53:01]

I guess I'll just rename so we have DecryptAndDecodeVideo/DecryptAndDecodeAudio
or DecryptAndDecodeFrame/DecryptAndDecodeSamples.

Either one is okay for me but I prefer the former. Frame/Samples is what's used
in CDM now. But it may not be obvious for people not familiar w/ this code that
frame is for video and samples is for audio.

 
   // There are 2 implementations of the fullscreen interface
   // PPB_FlashFullscreen is used by Pepper Flash.
   // PPB_Fullscreen is intended for other applications including NaCl.
   // The two interface are mutually exclusive.
 
   // Implementation of PPB_FlashFullscreen.
 
   // Because going to fullscreen is asynchronous (but going out is not), there
   // are 3 states:
@@ skipping 484 matching lines @@
   // We store the arguments so we can re-send them if we are reset to talk to
   // NaCl via the IPC NaCl proxy.
   std::vector<std::string> argn_;
   std::vector<std::string> argv_;
 
   // This is NULL unless HandleDocumentLoad has called. In that case, we store
   // the pointer so we can re-send it later if we are reset to talk to NaCl.
   scoped_refptr<PPB_URLLoader_Impl> document_loader_;
 
   media::DecryptorClient* decryptor_client_;
+
+  // Request ID for tracking pending content decryption callbacks.
+  // Note that zero indicates an invalid request ID.
+  // TODO(xhwang): Add completion callbacks for Reset/Stop and remove the use
+  // of request IDs.
   uint32_t next_decryption_request_id_;
+
+  // TODO(xhwang): Use two separate callbacks for video and audio instead using
+  // a map here.
   typedef std::map<uint32_t, media::Decryptor::DecryptCB> DecryptionCBMap;
   DecryptionCBMap pending_decryption_cbs_;
 
+  uint32_t pending_video_decoder_init_request_id_;
+  media::Decryptor::DecoderInitCB pending_video_decoder_init_cb_;
+
+  uint32_t pending_video_decode_request_id_;
+  media::Decryptor::VideoDecodeCB pending_video_decode_cb_;
+
   DISALLOW_COPY_AND_ASSIGN(PluginInstance);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_