Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: visual_studio/NativeClientVSAddIn/create_package.py

Issue 11090079: Include svn revsion in AddIn Version (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« visual_studio/NativeClientVSAddIn/buildbot_run.py ('K') | « visual_studio/NativeClientVSAddIn/buildbot_run.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: visual_studio/NativeClientVSAddIn/create_package.py
diff --git a/visual_studio/NativeClientVSAddIn/create_package.py b/visual_studio/NativeClientVSAddIn/create_package.py
index 9dc3a15fda6c56f6a38c51d2c5b92b436b29b829..df3c4a7aaf7eba0b7270caf4f949c70b1e5a5597 100644
--- a/visual_studio/NativeClientVSAddIn/create_package.py
+++ b/visual_studio/NativeClientVSAddIn/create_package.py
@@ -98,12 +98,12 @@ def AddVersionModifiedAddinFile(archive):
Args:
archive: Already open archive file.
"""
- info = win32api.GetFileVersionInfo(ADDIN_ASSEMBLY, "\\")
- ms = info['FileVersionMS']
- ls = info['FileVersionLS']
- version = "[%i.%i.%i.%i]" % (
- win32api.HIWORD(ms), win32api.LOWORD(ms),
- win32api.HIWORD(ls), win32api.LOWORD(ls))
+ path = '\\VarFileInfo\\Translation'
+ pairs = win32api.GetFileVersionInfo(ADDIN_ASSEMBLY, path)
+ lang, codepage = pairs[0]
+ path = u'\\StringFileInfo\\%04X%04X\\ProductVersion' % (lang, codepage)
binji 2012/10/11 20:23:00 needs to be unicode string?
+ prodVersion = win32api.GetFileVersionInfo(ADDIN_ASSEMBLY, path)
+ version = "[%s]" % prodVersion
print "\nNaCl VS Add-in Build version: %s\n" % (version)
metadata_filename = os.path.basename(ADDIN_METADATA)
« visual_studio/NativeClientVSAddIn/buildbot_run.py ('K') | « visual_studio/NativeClientVSAddIn/buildbot_run.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698