Include svn revsion in AddIn Version

visual_studio/NativeClientVSAddIn/buildbot_run.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file
 
 """Entry point for the AddIn build bot.
 
 Perform build steps and output results using the buildbot
 annootator syntax
 """
 
 import os
 import sys
+import re
+import shutil
 import subprocess
 import urllib2
 import zipfile
 
 GSURL = 'https://commondatastorage.googleapis.com'
 GSPATH = 'nativeclient-mirror/nacl/nacl_sdk/sdk'
 SDKROOT = os.path.join('..', '..', 'out', 'sdk')
 
 
 def Log(msg):
@@ skipping 15 matching lines @@
 
   rtn = subprocess.call(cmd, env=env)
   if rtn:
     Log("Command returned non-zero exit code: %s" % rtn)
     Log('@@@STEP_FAILURE@@@')
     sys.exit(1)
 
 
 def StepBuild():
   Log('@@@BUILD_STEP build AddIn@@@')
-  RunCommand('build.bat')
+
+  rev = os.environ.get('BUILDBOT_GOT_REVISION')
+  if not rev:
+    Log('No BUILDBOT_GOT_REVISION found in environ')
+    Log('@@@STEP_FAILURE@@@')
+    sys.exit(1)
+
+  if rev[0] == 'r':
+    rev = [1:]
+
+  # make a backup of AssemblyInfo.cs before we modify it
+  filename = os.path.join('NativeClientVSAddIn', 'AssemblyInfo.cs')
+  backup = filename + '.orig'
+  shutil.copyfile(filename, backup)
+
+  try:
+    # Before we do the build, insert the revsion information
+    # info AssemblyInfo.cs.  Thie will then be reported as
+    # the addin version in visual studio.
+    with open(filename, 'rb') as f:
+      contents = f.read()
+
+    pattern = r'(\[assembly: AssemblyInformationalVersion\("\d+\.\d+\.).*"\)\]'

[binji, 2012/10/11 20:23:00]

I think this regexp should extract the end part too... also, use a non-greedy
match for the part you're replacing:

\("\d+\.\d+\.).*?("\)\])

then sub using \1%s\2

Could also use lookbehind and lookahead assertions here, but maybe that's
overkill.

+    contents = re.sub(pattern, r'\1%s")]' % rev, contents)
+
+    with open(filename, 'wb') as f:
+      f.write(contents)
+
+    RunCommand('build.bat')
+  finally:
+    # Once build is done restore original file
+    os.remove(filename)
+    os.rename(backup, filename)
+
 
 
 def StepInstall():
   Log('@@@BUILD_STEP Install AddIn@@@')
   RunCommand('developer_deploy.bat')
 
 
 def StepInstallSDK():
   Log('@@@BUILD_STEP Install SDK@@@')
   naclsdk = os.path.join(SDKROOT, 'nacl_sdk', 'naclsdk.bat')
@@ skipping 88 matching lines @@
 def main():
   StepBuild()
   StepInstall()
   StepInstallSDK()
   StepTest()
   StepArchive()
 
 
 if __name__ == '__main__':
   main()