[Chromoting] Add a simple Windows app that registers and starts a host.

remoting/host/setup/win/host_configurer_window.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_SETUP_WIN_HOST_CONFIGURER_WINDOW_H_
+#define REMOTING_HOST_SETUP_WIN_HOST_CONFIGURER_WINDOW_H_
+
+// altbase.h must be included before atlapp.h
+#include <atlbase.h>
+#include <atlapp.h>
+#include <atlcrack.h>
+#include <atlwin.h>
+#include <atluser.h>

[alexeypa (please no reviews), 2012/10/11 16:57:52]

nit: swap atlwin and atluser

[simonmorris, 2012/10/11 21:27:35]

Done.

+#include <string>
+
+#include "base/basictypes.h"
+#include "net/url_request/url_request_context_getter.h"
+#include "remoting/host/setup/win/host_configurer_resource.h"
+
+namespace remoting {
+
+class HostConfigurerWindow : public ATL::CDialogImpl<HostConfigurerWindow> {
+ public:
+  enum { IDD = IDD_MAIN };
+
+  BEGIN_MSG_MAP_EX(HostConfigurerWindow)
+    MSG_WM_INITDIALOG(OnInitDialog)
+    MSG_WM_CLOSE(OnClose)
+    COMMAND_ID_HANDLER_EX(IDC_START_HOST, OnStartHost)
+  END_MSG_MAP()
+
+  HostConfigurerWindow(
+      net::URLRequestContextGetter* url_request_context_getter);
+
+ private:
+  void OnCancel(UINT code, int id, HWND control);
+  void OnClose();
+  LRESULT OnInitDialog(HWND wparam, LPARAM lparam);
+  void OnOk(UINT code, int id, HWND control);
+  void OnStartHost(UINT code, int id, HWND control);
+  // Sets an appropriate initial position for the dialog.

[alexeypa (please no reviews), 2012/10/11 16:57:52]

nit: Separate the message handlers from the following code by a blank line.

[simonmorris, 2012/10/11 21:27:35]

Done.

+  void PositionWindow();
+
+  net::URLRequestContextGetter* url_request_context_getter_;

[alexeypa (please no reviews), 2012/10/11 16:57:52]

scoped_reptf? Please add a quick comment what this member is for.

[simonmorris, 2012/10/11 21:27:35]

I don't think scoped_refptr adds anything here. The context getter has to
outlive this object, and it will do so.

I've added an explanatory comment.

[alexeypa (please no reviews), 2012/10/12 17:09:35]

It is not apparent from the code. scoped_refptr provides a strong guarantee,
while keeping it a raw pointer requires the maintainer of the code to be very
careful.

[simonmorris, 2012/10/15 16:51:41]

One result of that guarantee is that it becomes impossible to know when the
pointee will be destroyed. See willchan@'s rant. But I don't think it's
important here, so I've moved to scoped_refptr.

Done.

[alexeypa (please no reviews), 2012/10/15 18:48:55]

It is not possible to know without scoped_refptr as well. Having scoped_refptr
actually makes the situation more defined - the object will not be killed before
the reference is released, while before it potentially could.

[Sergey Ulanov, 2012/10/15 23:44:26]

+1 on this. Using raw pointer for ref-counted object is wrong.
willchan was ranting about using ref-counting at all, not about usage of
scoped_refptr for ref-counted objects.

+
+  DISALLOW_COPY_AND_ASSIGN(HostConfigurerWindow);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_SETUP_WIN_HOST_CONFIGURER_WINDOW_H_