Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: webkit/fileapi/syncable/canned_syncable_file_system.h

Issue 11090019: Add LocalFileSyncContext class which wires up profile-owned service and FileSystemContext(s) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments #2 Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/syncable/canned_syncable_file_system.h
diff --git a/webkit/fileapi/syncable/canned_syncable_file_system.h b/webkit/fileapi/syncable/canned_syncable_file_system.h
index e8935f71858cea5b1a8a01f7c8ce2f4c61337583..a57113108a1665d6eb8cf696632e8bd7634e6497 100644
--- a/webkit/fileapi/syncable/canned_syncable_file_system.h
+++ b/webkit/fileapi/syncable/canned_syncable_file_system.h
@@ -27,6 +27,7 @@ class QuotaManager;
namespace fileapi {
class FileSystemContext;
+class SyncableContext;
// A canned syncable filesystem for testing.
// This internally creates its own QuotaManager and FileSystemContext
@@ -45,6 +46,11 @@ class CannedSyncableFileSystem {
// Creates a FileSystemURL for the given (utf8) path string.
FileSystemURL URL(const std::string& path) const;
+ // Initialize this with given |syncable_context| if it hasn't
+ // been initialized.
+ SyncStatusCode MaybeInitializeFileSystemContext(
+ SyncableContext* syncable_context);
+
// Opens a new syncable file system.
base::PlatformFileError OpenFileSystem();
@@ -60,6 +66,7 @@ class CannedSyncableFileSystem {
}
// Helper routines to perform file system operations.
+ // OpenFileSystem() must have been called before calling any of them.
// (They run on the current thread and returns synchronously).
base::PlatformFileError CreateDirectory(const FileSystemURL& url);
base::PlatformFileError CreateFile(const FileSystemURL& url);
@@ -74,6 +81,7 @@ class CannedSyncableFileSystem {
void DidOpenFileSystem(base::PlatformFileError result,
const std::string& name,
const GURL& root);
+ void DidInitializeFileSystemContext(SyncStatusCode status);
void StatusCallback(base::PlatformFileError result);
FileSystemOperationContext* NewOperationContext();
@@ -88,6 +96,10 @@ class CannedSyncableFileSystem {
base::PlatformFileError result_;
SyncStatusCode sync_status_;
+ // Boolean flags mainly for helping debug.
+ bool is_filesystem_set_up_;
+ bool is_filesystem_opened_;
+
base::WeakPtrFactory<CannedSyncableFileSystem> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(CannedSyncableFileSystem);

Powered by Google App Engine
This is Rietveld 408576698