browser-plugin: Allow accepting drag-n-drop events.

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/string_util.h"
 #include "content/browser/browser_plugin/browser_plugin_guest_helper.h"
 #include "content/browser/browser_plugin/browser_plugin_host_factory.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/browser_plugin_messages.h"
 #include "content/common/view_messages.h"
+#include "content/port/browser/render_view_host_delegate_view.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/resource_request_details.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/common/result_codes.h"
 #include "content/browser/browser_plugin/browser_plugin_host_factory.h"
 #include "net/base/net_errors.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebCursorInfo.h"
 #include "ui/surface/transport_dib.h"
+#include "webkit/glue/webdropdata.h"
 #include "webkit/glue/resource_type.h"
 
 namespace content {
 
 // static
 BrowserPluginHostFactory* BrowserPluginGuest::factory_ = NULL;
 
 namespace {
 const int kGuestHangTimeoutMs = 5000;
 }
 
 BrowserPluginGuest::BrowserPluginGuest(int instance_id,
                                        WebContentsImpl* web_contents,
                                        RenderViewHost* render_view_host)
     : WebContentsObserver(web_contents),
       embedder_render_process_host_(NULL),
+      embedder_render_view_host_(NULL),
       instance_id_(instance_id),
 #if defined(OS_WIN)
       damage_buffer_size_(0),
 #endif
       damage_buffer_scale_factor_(1.0f),
       pending_update_counter_(0),
       guest_hang_timeout_(
           base::TimeDelta::FromMilliseconds(kGuestHangTimeoutMs)),
       visible_(true) {
   DCHECK(web_contents);
@@ skipping 84 matching lines @@
 }
 
 void BrowserPluginGuest::SetVisibility(bool embedder_visible, bool visible) {
   visible_ = visible;
   if (embedder_visible && visible)
     web_contents()->WasShown();
   else
     web_contents()->WasHidden();
 }
 
+void BrowserPluginGuest::DragStatusUpdate(WebKit::WebDragStatus drag_status,
+                                          const WebDropData& drop_data,
+                                          WebKit::WebDragOperationsMask mask,
+                                          const gfx::Point& location) {
+  RenderViewHost* host = web_contents()->GetRenderViewHost();
+  switch (drag_status) {
+    case WebKit::WebDragStatusEnter:
+      host->DragTargetDragEnter(drop_data, location, location, mask, 0);
+      break;
+    case WebKit::WebDragStatusOver:
+      host->DragTargetDragOver(location, location, mask, 0);
+      break;
+    case WebKit::WebDragStatusLeave:
+      host->DragTargetDragLeave();
+      break;
+    case WebKit::WebDragStatusDrop:
+      host->DragTargetDrop(location, location, 0);
+      break;
+    case WebKit::WebDragStatusUnknown:
+      NOTREACHED();
+  }
+}
+
+void BrowserPluginGuest::UpdateDragCursor(WebKit::WebDragOperation operation) {
+  if (embedder_render_view_host_) {

[Charlie Reis, 2012/10/11 18:02:52]

I thought it wasn't possible for this to be invalid.  Maybe it's better to let
it crash on a null deref below if that assumption is incorrect, so that we can
track it down and fix it.  Otherwise we'll never know that the drag cursor is
broken.

[sadrul, 2012/10/11 18:31:18]

Sounds good. Done.

+    RenderViewHostDelegateView* view =
+        embedder_render_view_host_->GetDelegate()->GetDelegateView();
+    if (view)
+      view->UpdateDragCursor(operation);
+  }
+}
+
 WebContents* BrowserPluginGuest::GetWebContents() {
   return web_contents();
 }
 
 void BrowserPluginGuest::Terminate() {
   RecordAction(UserMetricsAction("BrowserPlugin.Guest.Terminate"));
   base::ProcessHandle process_handle =
       web_contents()->GetRenderProcessHost()->GetHandle();
   base::KillProcess(process_handle, RESULT_CODE_KILLED, false);
 }
@@ skipping 265 matching lines @@
       break;
   }
 }
 
 void BrowserPluginGuest::SendMessageToEmbedder(IPC::Message* msg) {
   DCHECK(embedder_render_process_host());
   embedder_render_process_host()->Send(msg);
 }
 
 }  // namespace content