Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4006)

Unified Diff: chrome/browser/system_monitor/removable_device_notifications_window_win.h

Issue 11088012: [Win, MediaGallery] Enumerate and handle mtp device attach/detach events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/system_monitor/removable_device_notifications_window_win.h
diff --git a/chrome/browser/system_monitor/removable_device_notifications_window_win.h b/chrome/browser/system_monitor/removable_device_notifications_window_win.h
index 173e7ec56287dca09d87a73df7d08f8d2a8195c9..7ef1eceaaf06bee510dcd1acd5cb0ad81c7be5b9 100644
--- a/chrome/browser/system_monitor/removable_device_notifications_window_win.h
+++ b/chrome/browser/system_monitor/removable_device_notifications_window_win.h
@@ -5,16 +5,18 @@
#ifndef CHROME_BROWSER_SYSTEM_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_WINDOW_WIN_H_
#define CHROME_BROWSER_SYSTEM_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_WINDOW_WIN_H_
-#include <windows.h>
-
#include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
#include "base/system_monitor/system_monitor.h"
-#include "chrome/browser/system_monitor/volume_mount_watcher_win.h"
class FilePath;
namespace chrome {
+class PortableDeviceWatcherWin;
+class VolumeMountWatcherWin;
+
class RemovableDeviceNotificationsWindowWin;
typedef RemovableDeviceNotificationsWindowWin RemovableDeviceNotifications;
@@ -40,10 +42,12 @@ class RemovableDeviceNotificationsWindowWin {
base::SystemMonitor::RemovableStorageInfo* device_info);
private:
+ class PortableDeviceNotifications;
friend class TestRemovableDeviceNotificationsWindowWin;
- explicit RemovableDeviceNotificationsWindowWin(
- VolumeMountWatcherWin* volume_mount_watcher);
+ RemovableDeviceNotificationsWindowWin(
Peter Kasting 2012/10/29 21:57:19 Nit: Add comments about why we take these objects
kmadhusu 2012/10/30 01:29:24 Done.
+ VolumeMountWatcherWin* volume_mount_watcher,
+ PortableDeviceWatcherWin* portable_device_watcher);
// Gets the removable storage information given a |device_path|. On success,
// returns true and fills in |device_location|, |unique_id|, |name| and
@@ -69,9 +73,16 @@ class RemovableDeviceNotificationsWindowWin {
HMODULE instance_;
HWND window_;
+ // Manages portable device notification handle for
+ // RemovableDeviceNotificationsWindowWin.
+ scoped_ptr<PortableDeviceNotifications> portable_device_notifications_;
+
// Store the volume mount point watcher to manage the mounted devices.
scoped_refptr<VolumeMountWatcherWin> volume_mount_watcher_;
+ // Store the portable device watcher to manage mtp devices.
+ scoped_ptr<PortableDeviceWatcherWin> portable_device_watcher_;
+
DISALLOW_COPY_AND_ASSIGN(RemovableDeviceNotificationsWindowWin);
};

Powered by Google App Engine
This is Rietveld 408576698