chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm - Issue 11087071: Making ShowExtensionInstallDialog a callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_install_prompt.cc ('K') | « chrome/browser/ui/android/extensions/extension_install_dialog_android.cc ('k') | chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

index 9bd8c8e804ae1b35ca76cb3a098ee4f6ac5bcebc..ab553aca6e1bc78370de6e03b807440530921350 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

@@ -12,7 +12,6 @@

#include "base/sys_string_conversions.h"

#include "base/utf_string_conversions.h"

#include "chrome/browser/extensions/bundle_installer.h"

-#include "chrome/browser/extensions/extension_install_dialog.h"

#include "chrome/common/extensions/extension.h"

#include "content/public/browser/page_navigator.h"

#include "grit/generated_resources.h"