Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2885)

Unified Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix android build Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
diff --git a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
index f8db72cfdfd798c2a7643c7c63fa58837405dd11..3ccac71e2fa9e9d96c214e039f3ee477ca1e1947 100644
--- a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
+++ b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
@@ -8,7 +8,7 @@
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/extensions/bundle_installer.h"
-#include "chrome/browser/extensions/extension_install_dialog.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/gtk/browser_window_gtk.h"
#include "chrome/browser/ui/gtk/gtk_chrome_link_button.h"
@@ -383,6 +383,8 @@ GtkWidget* ExtensionInstallDialog::CreateWidgetForIssueAdvice(
} // namespace browser
+namespace {
+
void ShowExtensionInstallDialogImpl(
gfx::NativeWindow parent,
content::PageNavigator* navigator,
@@ -390,3 +392,11 @@ void ShowExtensionInstallDialogImpl(
const ExtensionInstallPrompt::Prompt& prompt) {
new browser::ExtensionInstallDialog(parent, navigator, delegate, prompt);
}
+
+} // namespace
+
+// static
+ExtensionInstallPrompt::ShowDialogCallback
+ExtensionInstallPrompt::GetDefaultShowDialogCallback() {
+ return base::Bind(&ShowExtensionInstallDialogImpl);
+}

Powered by Google App Engine
This is Rietveld 408576698