chrome/browser/extensions/bundle_installer.cc - Issue 11087071: Making ShowExtensionInstallDialog a callback

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/bundle_installer.cc

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('K') | « chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | chrome/browser/extensions/extension_install_prompt.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/bundle_installer.h"	5 #include "chrome/browser/extensions/bundle_installer.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

11 #include "base/command_line.h"	11 #include "base/command_line.h"

12 #include "base/i18n/rtl.h"	12 #include "base/i18n/rtl.h"

13 #include "base/utf_string_conversions.h"	13 #include "base/utf_string_conversions.h"

14 #include "base/values.h"	14 #include "base/values.h"

15 #include "chrome/browser/extensions/crx_installer.h"	15 #include "chrome/browser/extensions/crx_installer.h"

16 #include "chrome/browser/extensions/extension_install_dialog.h"

17 #include "chrome/browser/profiles/profile.h"	16 #include "chrome/browser/profiles/profile.h"

18 #include "chrome/browser/ui/browser.h"	17 #include "chrome/browser/ui/browser.h"

19 #include "chrome/browser/ui/browser_list.h"	18 #include "chrome/browser/ui/browser_list.h"

20 #include "chrome/browser/ui/browser_finder.h"	19 #include "chrome/browser/ui/browser_finder.h"

21 #include "chrome/common/chrome_switches.h"	20 #include "chrome/common/chrome_switches.h"

22 #include "chrome/common/extensions/extension.h"	21 #include "chrome/common/extensions/extension.h"

23 #include "chrome/common/extensions/extension_manifest_constants.h"	22 #include "chrome/common/extensions/extension_manifest_constants.h"

24 #include "chrome/common/extensions/permissions/permission_set.h"	23 #include "chrome/common/extensions/permissions/permission_set.h"

25 #include "content/public/browser/browser_thread.h"	24 #include "content/public/browser/browser_thread.h"

26 #include "content/public/browser/navigation_controller.h"	25 #include "content/public/browser/navigation_controller.h"

(...skipping 317 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
344 void BundleInstaller::OnBrowserAdded(Browser* browser) {}	343 void BundleInstaller::OnBrowserAdded(Browser* browser) {}

345	344

346 void BundleInstaller::OnBrowserRemoved(Browser* browser) {	345 void BundleInstaller::OnBrowserRemoved(Browser* browser) {

347 if (browser_ == browser)	346 if (browser_ == browser)

348 browser_ = NULL;	347 browser_ = NULL;

349 }	348 }

350	349

351 void BundleInstaller::OnBrowserSetLastActive(Browser* browser) {}	350 void BundleInstaller::OnBrowserSetLastActive(Browser* browser) {}

352	351

353 } // namespace extensions	352 } // namespace extensions

OLD	NEW