Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: remoting/base/resources_unittest.cc

Issue 11087059: Add common_resources.grd for non-localizeable chromoting resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/resources_unittest.cc
diff --git a/remoting/base/resources_unittest.cc b/remoting/base/resources_unittest.cc
index f04a34b0870289b4aa6d2d81dba0eedad2c7f94c..15f1eeb3183856fd3bfafe1221b409944d41598b 100644
--- a/remoting/base/resources_unittest.cc
+++ b/remoting/base/resources_unittest.cc
@@ -4,6 +4,7 @@
#include "remoting/base/resources.h"
+#include "remoting/base/common_resources.h"
#include "remoting/base/string_resources.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -15,19 +16,37 @@ namespace remoting {
// the test.
#if !defined(OS_MACOS)
#define MAYBE_ProductName ProductName
+#define MAYBE_ProductLogo ProductLogo
#else // !defined(OS_MACOS)
#define MAYBE_ProductName DISABLED_ProductName
+#define MAYBE_ProductLogo DISABLED_ProductLogo
#endif // defined(OS_MACOS)
-TEST(Resources, MAYBE_ProductName) {
+
+class ResourcesTest : public testing::Test {
+ protected:
+ void SetUp() OVERRIDE {
+ ASSERT_TRUE(LoadResources("en-US"));
+ }
+
+ void TearDown() OVERRIDE {
+ ui::ResourceBundle::CleanupSharedInstance();
+ }
+};
+
+TEST_F(ResourcesTest, MAYBE_ProductName) {
#if defined(GOOGLE_CHROME_BUILD)
std::string expected_product_name = "Chrome Remote Desktop";
#else // defined(GOOGLE_CHROME_BUILD)
std::string expected_product_name = "Chromoting";
#endif // !defined(GOOGLE_CHROME_BUILD)
- ASSERT_TRUE(LoadResources("en-US"));
EXPECT_EQ(expected_product_name,
l10n_util::GetStringUTF8(IDR_REMOTING_PRODUCT_NAME));
- ui::ResourceBundle::CleanupSharedInstance();
+}
+
+TEST_F(ResourcesTest, MAYBE_ProductLogo) {
+ gfx::Image logo = ui::ResourceBundle::GetSharedInstance().GetImageNamed(
+ IDR_PRODUCT_LOGO_16);
+ EXPECT_FALSE(logo.IsEmpty());
}
} // namespace remoting
« no previous file with comments | « remoting/base/resources.cc ('k') | remoting/grit_action.gypi » ('j') | remoting/remoting.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698