Fix to dartbug.com/5170, explictly static library variables now get an appropriate error message.

lib/compiler/implementation/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 abstract class TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   DartType getType(TypeAnnotation annotation);
   bool isParameterChecked(Element element);
 }
@@ skipping 295 matching lines @@
 
     if (constructor.defaultImplementation === null) {
       // We failed to find a constructor named either
       // "MyInterface.name" or "MyClass.name".
       error(node,
             MessageKind.CANNOT_FIND_CONSTRUCTOR2,
             [name, defaultClass.name]);
     }
   }
 
   TreeElements resolveField(Element element) {

[ahe, 2012/10/09 10:20:09]

Element -> VariableElement.

[jwren, 2012/10/09 10:31:15]

Done.

     Node tree = element.parseNode(compiler);
+    if(element.modifiers.isStatic() && element.getEnclosingClassOrCompilationUnit().isCompilationUnit()) {

[ahe, 2012/10/09 10:20:09]

Long line.

[ahe, 2012/10/09 10:20:09]

I think it should element.variables.isTopLevel(), not element.getEnclosing...

[jwren, 2012/10/09 10:31:15]

Done- changing it to element.variables.isTopLevel() shorten the length of the
line down to 73 chars.

+      error(tree, MessageKind.LIBRARY_VARIABLE_AS_STATIC, [element.name]);
+    }
     ResolverVisitor visitor = new ResolverVisitor(compiler, element);
     initializerDo(tree, visitor.visit);
     return visitor.mapping;
   }
 
   TreeElements resolveParameter(Element element) {
     Node tree = element.parseNode(compiler);
     ResolverVisitor visitor =
         new ResolverVisitor(compiler, element.enclosingElement);
     initializerDo(tree, visitor.visit);
@@ skipping 2804 matching lines @@
     return result;
   }
   Element lookup(SourceString name) => localLookup(name);
   Element lexicalLookup(SourceString name) => localLookup(name);
 
   Element add(Element newElement) {
     throw "Cannot add an element in a patch library scope";
   }
   String toString() => 'PatchLibraryScope($origin,$patch)';
 }