Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: ui/gfx/render_text_win.cc

Issue 11087016: Create font with DEFAULT_CHARSET instead of ANSI_CHARSET. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/platform_font_win.cc ('K') | « ui/gfx/platform_font_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_win.cc
===================================================================
--- ui/gfx/render_text_win.cc (revision 160607)
+++ ui/gfx/render_text_win.cc (working copy)
@@ -646,7 +646,8 @@
HRESULT hr = ShapeTextRunWithFont(run, current_font);
bool glyphs_missing = false;
- if (hr == USP_E_SCRIPT_NOT_IN_FONT) {
+ if (hr == USP_E_SCRIPT_NOT_IN_FONT ||
+ hr == __HRESULT_FROM_WIN32(ERROR_INVALID_WINDOW_HANDLE)) {
msw 2012/10/12 20:50:57 1) Why is this in the same patch? It looks like a
Vitaly Buka (NO REVIEWS) 2012/10/12 21:11:33 Because this happens always when I reproduce bug a
Vitaly Buka (NO REVIEWS) 2012/10/12 21:14:19 I never see crash like that
glyphs_missing = true;
} else if (hr == S_OK) {
// If |hr| is S_OK, there could still be missing glyphs in the output.
« ui/gfx/platform_font_win.cc ('K') | « ui/gfx/platform_font_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698