Chromium Code Reviews| Index: src/spaces.h |
| diff --git a/src/spaces.h b/src/spaces.h |
| index effe06b031ac960f2cf5fc58904ca7bd573ced8c..d2442a870a59601ee07cfbce3caebf64ca74c2d9 100644 |
| --- a/src/spaces.h |
| +++ b/src/spaces.h |
| @@ -1574,20 +1574,20 @@ class PagedSpace : public Space { |
| // The dummy page that anchors the linked list of pages. |
| Page* anchor() { return &anchor_; } |
| -#ifdef DEBUG |
| - // Print meta info and objects in this space. |
| - virtual void Print(); |
| - |
| // Verify integrity of this space. |
| virtual void Verify(ObjectVisitor* visitor); |
| - // Reports statistics for the space |
| - void ReportStatistics(); |
| - |
| // Overridden by subclasses to verify space-specific object |
| // properties (e.g., only maps or free-list nodes are in map space). |
| virtual void VerifyObject(HeapObject* obj) {} |
| +#ifdef DEBUG |
| + // Print meta info and objects in this space. |
| + virtual void Print(); |
| + |
| + // Reports statistics for the space |
| + void ReportStatistics(); |
| + |
| // Report code object related statistics |
| void CollectCodeStatistics(); |
| static void ReportCodeStatistics(); |
| @@ -1934,9 +1934,10 @@ class SemiSpace : public Space { |
| NewSpacePage* first_page() { return anchor_.next_page(); } |
| NewSpacePage* current_page() { return current_page_; } |
| + virtual void Verify(); |
| + |
| #ifdef DEBUG |
| virtual void Print(); |
| - virtual void Verify(); |
| // Validate a range of of addresses in a SemiSpace. |
| // The "from" address must be on a page prior to the "to" address, |
| // in the linked page order, or it must be earlier on the same page. |
| @@ -2261,9 +2262,10 @@ class NewSpace : public Space { |
| template <typename StringType> |
| inline void ShrinkStringAtAllocationBoundary(String* string, int len); |
| -#ifdef DEBUG |
| // Verify the active semispace. |
| virtual void Verify(); |
| + |
| +#ifdef DEBUG |
| // Print the active semispace. |
| virtual void Print() { to_space_.Print(); } |
| #endif |
| @@ -2433,9 +2435,7 @@ class MapSpace : public FixedSpace { |
| } |
| protected: |
| -#ifdef DEBUG |
| virtual void VerifyObject(HeapObject* obj); |
| -#endif |
| private: |
| static const int kMapsPerPage = Page::kNonCodeObjectAreaSize / Map::kSize; |
| @@ -2471,9 +2471,7 @@ class CellSpace : public FixedSpace { |
| } |
| protected: |
| -#ifdef DEBUG |
| virtual void VerifyObject(HeapObject* obj); |
| -#endif |
| public: |
| TRACK_MEMORY("CellSpace") |
| @@ -2552,8 +2550,8 @@ class LargeObjectSpace : public Space { |
| LargePage* first_page() { return first_page_; } |
| -#ifdef DEBUG |
| virtual void Verify(); |
|
Michael Starzinger
2012/10/11 12:42:46
Empty newline after declaration.
mvstanton1
2012/10/12 08:40:50
Done.
|
| +#ifdef DEBUG |
| virtual void Print(); |
| void ReportStatistics(); |
| void CollectCodeStatistics(); |