Improving window auto management between workspaces

chrome/browser/ui/views/tabs/tab_drag_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/tab_drag_controller.h"
 
 #include <math.h>
 #include <set>
 
 #include "base/auto_reset.h"
@@ skipping 29 matching lines @@
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/screen.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(USE_ASH)
 #include "ash/shell.h"
 #include "ash/wm/property_util.h"
+#include "ash/wm/window_util.h"
 #include "ui/aura/env.h"
 #include "ui/aura/root_window.h"
 #include "ui/base/gestures/gesture_recognizer.h"
 #endif
 
 using content::OpenURLParams;
 using content::UserMetricsAction;
 using content::WebContents;
 
 static const int kHorizontalMoveThreshold = 16;  // Pixels.
@@ skipping 761 matching lines @@
     attached_tabstrip_->ReleaseDragController();
     target_tabstrip->OwnDragController(this);
     // Disable animations so that we don't see a close animation on aero.
     browser_widget->SetVisibilityChangedAnimationsEnabled(false);
     // For aura we can't release capture, otherwise it'll cancel a gesture.
     // Instead we have to directly change capture.
 #if !defined(USE_ASH)
     browser_widget->ReleaseCapture();
 #else
     target_tabstrip->GetWidget()->SetCapture(attached_tabstrip_);
+    // To avoid the auto window management to kick in we set the user changed

[sky, 2012/10/23 19:35:39]

What we're saying is that when you drag a window as the result of tab dragging
it should disable auto-management. So, the code should do that. Have RunLoop
(and DetachIntoNewBrowserAndRunMoveLoop) disable window management on the
window. That way the auto-management code isn't looking at yet another property
(meaning you can remove the code that looks at GetTrackedByWorkspace).

[Mr4D (OOO till 08-26), 2012/10/24 16:41:37]

Done indirectly as requested. 

+    // flag. Note that the browser might only have a single tab left at this
+    // point and if that happens it will be destroyed shortly after in which
+    // case we don't want to ever take back the flag.
+    bool old_state = true;
+    if (GetModel(attached_tabstrip_)->count() > 1)
+      old_state = ash::wm::HasUserChangedWindowPositionOrSize(
+          browser_widget->GetNativeWindow());
+    ash::wm::SetUserHasChangedWindowPositionOrSize(
+        browser_widget->GetNativeWindow(), true);
 #endif
     // EndMoveLoop is going to snap the window back to its original location.
     // Hide it so users don't see this.
     browser_widget->Hide();
     browser_widget->EndMoveLoop();
 
     // Ideally we would always swap the tabs now, but on windows it seems that
     // running the move loop implicitly activates the window when done, leading
     // to all sorts of flicker. So, on windows, instead we process the move
     // after the loop completes. But on chromeos, we can do tab swapping now to
     // avoid the tab flashing issue(crbug.com/116329).
 #if defined(USE_ASH)
+    if (!old_state)
+      ash::wm::SetUserHasChangedWindowPositionOrSize(
+          browser_widget->GetNativeWindow(), old_state);
     is_dragging_window_ = false;
     Detach(DONT_RELEASE_CAPTURE);
     Attach(target_tabstrip, point_in_screen);
     // Move the tabs into position.
     MoveAttached(point_in_screen);
     attached_tabstrip_->GetWidget()->Activate();
 #else
     tab_strip_to_attach_to_after_exit_ = target_tabstrip;
 #endif
 
@@ skipping 448 matching lines @@
 
   browser->window()->Show();
   browser->window()->Activate();
   dragged_browser_view->GetWidget()->SetVisibilityChangedAnimationsEnabled(
       true);
   RunMoveLoop(drag_offset);
 }
 
 void TabDragController::RunMoveLoop(const gfx::Point& drag_offset) {
   // If the user drags the whole window we'll assume they are going to attach to
-  // another window and therefor want to reorder.
+  // another window and therefore want to reorder.
   move_behavior_ = REORDER;
 
   move_loop_widget_ = GetAttachedBrowserWidget();
   DCHECK(move_loop_widget_);
   move_loop_widget_->AddObserver(this);
   is_dragging_window_ = true;
   bool destroyed = false;
   destroyed_ = &destroyed;
 #if !defined(USE_ASH)
   // Running the move loop releases mouse capture on Windows, which triggers
@@ skipping 675 matching lines @@
 gfx::Point TabDragController::GetWindowOffset(
     const gfx::Point& point_in_screen) {
   TabStrip* owning_tabstrip = (attached_tabstrip_ && detach_into_browser_) ?
       attached_tabstrip_ : source_tabstrip_;
   views::View* toplevel_view = owning_tabstrip->GetWidget()->GetContentsView();
 
   gfx::Point offset = point_in_screen;
   views::View::ConvertPointFromScreen(toplevel_view, &offset);
   return offset;
 }