Issue 11085048: Allow to specify resources_ids file in grit_info.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11085048: Allow to specify resources_ids file in grit_info.py. (Closed)

Created:
8 years, 2 months ago by Sergey Ulanov

Modified:
8 years, 2 months ago

Reviewers:
Jói

CC:
grit-developer_googlegroups.com

Base URL:
http://git.chromium.org/external/grit-i18n.git@master

Visibility:
Public.

More Reviews

Description

Allow to specify resources_ids file in grit_info.py. Previously location of resources_ids was hard-coded in grit_info.py.

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -20 lines)			Patch
	M	grit_info.py	View		6 chunks	+12 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jói

8 years, 2 months ago (2012-10-11 11:18:55 UTC) #3

On 2012/10/10 21:26:05, Jói wrote:
> LGTM

Sergey, I have landed this for you as
https://code.google.com/p/grit-i18n/source/detail?r=75

You can now update Chromium's src/DEPS to pull in the new version.

Cheers,
Jói

Expand Messages | Collapse Messages