Issue 1108001: Mere r4172 to trunk. The new version is 2.1.6.1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1108001: Mere r4172 to trunk. The new version is 2.1.6.1. (Closed)

Created:
10 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Mere r4172 and r4177 to trunk. The new version is 2.1.6.1. Committed: http://code.google.com/p/v8/source/detail?r=4178

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1	3 chunks	+27 lines, -0 lines	0 comments	Download
M	src/rewriter.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/compiler/loopcount.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM, with comments. Changes should be tested on bleeding edge again, with comments addressed, before ...

10 years, 9 months ago (2010-03-18 09:24:52 UTC) #2

fschneider

10 years, 9 months ago (2010-03-18 10:04:40 UTC) #3

Addressed comments. Merged the suggested changes from bleeding_edge.

http://codereview.chromium.org/1108001/diff/1/3
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1108001/diff/1/3#newcode6886
src/ia32/codegen-ia32.cc:6886: // The old value that is return for postfix
operations has the
On 2010/03/18 09:24:52, William Hesse wrote:
> The return value for postfix operations is the same as the input, and has the
> same number info.

Done.

http://codereview.chromium.org/1108001/diff/1/3#newcode6955
src/ia32/codegen-ia32.cc:6955: new_value.set_number_info(NumberInfo::Number());
On 2010/03/18 09:24:52, William Hesse wrote:
> Don't we know that it is an int32?

Done.

Expand Messages | Collapse Messages