chrome/browser/ui/constrained_window.h - Issue 11077006: Correct padding and focus ring for frameless constrained window dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/constrained_window.h

Issue 11077006: Correct padding and focus ring for frameless constrained window dialog (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/shared_resources.grd ('k') | chrome/browser/ui/views/constrained_window_frame_simple.h » ('j') | chrome/browser/ui/views/constrained_window_frame_simple.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/constrained_window.h

diff --git a/chrome/browser/ui/constrained_window.h b/chrome/browser/ui/constrained_window.h

index 21efd6512df764d60d64ccba88fbcdcaf2e02e3d..9b4a72bc34a8e3cda70c705eb5f42d838518da19 100644

--- a/chrome/browser/ui/constrained_window.h

+++ b/chrome/browser/ui/constrained_window.h

@@ -18,10 +18,12 @@

class ConstrainedWindow {

public:

- static const int kVerticalPadding = 14; // top/bottom padding.

- static const int kHorizontalPadding = 17; // left/right padding.

- static const int kRowPadding = 20; // Vertical margin between dialog rows.

- static const int kBorderRadius = 2; // Border radius for dialog corners.

+ static const int kTitleTopPadding = 15; // Padding above the title.

+ static const int kHorizontalPadding = 20; // Left and right padding.

+ static const int kClientTopPadding = 18; // Padding above the client view.

+ static const int kClientBottomPadding = 20; // Padding below the client view.

+ static const int kCloseButtonPadding = 7; // Padding around the close button.

+ static const int kBorderRadius = 2; // Border radius for dialog corners.

// Font style for dialog text.

static const ui::ResourceBundle::FontStyle kTextFontStyle =