Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7179)

Unified Diff: chrome/browser/ui/constrained_window.h

Issue 11077006: Correct padding and focus ring for frameless constrained window dialog (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/constrained_window.h
diff --git a/chrome/browser/ui/constrained_window.h b/chrome/browser/ui/constrained_window.h
index 04d529ca7b1c4941b6de17a6fd2f620201dd642f..1452bcd53150804f95b582e5532e65e0d8e30015 100644
--- a/chrome/browser/ui/constrained_window.h
+++ b/chrome/browser/ui/constrained_window.h
@@ -18,10 +18,11 @@
//
class ConstrainedWindow {
public:
- static const int kVerticalPadding = 14; // top/bottom padding.
- static const int kHorizontalPadding = 17; // left/right padding.
- static const int kRowPadding = 20; // Vertical margin between dialog rows.
+ static const int kVerticalPadding = 20; // top/bottom padding.
+ static const int kHorizontalPadding = 20; // left/right padding.
+ static const int kRowPadding = 11; // Vertical margin between dialog rows.
static const int kBorderRadius = 2; // Border radius for dialog corners.
+ static const int kCloseButtonPadding = 4; // Padding around the close button.
sail 2012/10/08 17:19:12 Could you reword this comment. Currently it doesn'
Mike Wittman 2012/10/08 21:34:19 I think it would be helpful to create an ASCII art
please use gerrit instead 2012/10/09 18:38:09 Done.
please use gerrit instead 2012/10/09 18:38:09 I admit that kCloseButtonPadding comment is confus
// Font style for dialog text.
static const ui::ResourceBundle::FontStyle kTextFontStyle =

Powered by Google App Engine
This is Rietveld 408576698