Correct padding and focus ring for frameless constrained window dialog

chrome/browser/ui/constrained_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_CONSTRAINED_WINDOW_H_
 #define CHROME_BROWSER_UI_CONSTRAINED_WINDOW_H_
 
 #include "build/build_config.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/native_widget_types.h"
 
 ///////////////////////////////////////////////////////////////////////////////
 // ConstrainedWindow
 //
 //  This interface represents a window that is constrained to a
 //  WebContentsView's bounds.
 //
 class ConstrainedWindow {
  public:
-  static const int kVerticalPadding = 14; // top/bottom padding.
-  static const int kHorizontalPadding = 17; // left/right padding.
-  static const int kRowPadding = 20;  // Vertical margin between dialog rows.
+  static const int kVerticalPadding = 20; // top/bottom padding.
+  static const int kHorizontalPadding = 20; // left/right padding.
+  static const int kRowPadding = 11;  // Vertical margin between dialog rows.
   static const int kBorderRadius = 2;  // Border radius for dialog corners.
+  static const int kCloseButtonPadding = 4; // Padding around the close button.

[sail, 2012/10/08 17:19:12]

Could you reword this comment. Currently it doesn't explain how to use this
value.

[Mike Wittman, 2012/10/08 21:34:19]

I think it would be helpful to create an ASCII art diagram to document the
layout constants.  It's likely to be difficult to understand solely via text
descriptions.

[please use gerrit instead, 2012/10/09 18:38:09]

Done.

[please use gerrit instead, 2012/10/09 18:38:09]

I admit that kCloseButtonPadding comment is confusing. Drew an ASCII diagram :)

 
   // Font style for dialog text.
   static const ui::ResourceBundle::FontStyle kTextFontStyle =
       ui::ResourceBundle::BaseFont;
   // Font style for bold dialog text.
   static const ui::ResourceBundle::FontStyle kBoldTextFontStyle =
       ui::ResourceBundle::BoldFont;
   // Font style for dialog title.
   static const ui::ResourceBundle::FontStyle kTitleFontStyle =
       ui::ResourceBundle::MediumFont;
@@ skipping 18 matching lines @@
   virtual bool CanShowConstrainedWindow();
 
   // Returns the native window of the constrained window.
   virtual gfx::NativeWindow GetNativeWindow();
 
  protected:
   virtual ~ConstrainedWindow() {}
 };
 
 #endif  // CHROME_BROWSER_UI_CONSTRAINED_WINDOW_H_