Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: runtime/vm/intrinsifier_x64.cc

Issue 11074016: Intrinsify writing to Uint8 and Int8 arrays on IA32. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 R12, 454 R12,
455 TIMES_1, 455 TIMES_1,
456 Int8Array::data_offset())); 456 Int8Array::data_offset()));
457 __ SmiTag(RAX); 457 __ SmiTag(RAX);
458 __ ret(); 458 __ ret();
459 __ Bind(&fall_through); 459 __ Bind(&fall_through);
460 return false; 460 return false;
461 } 461 }
462 462
463 463
464 bool Intrinsifier::Int8Array_setIndexed(Assembler* assembler) {
465 Label fall_through;
cshapiro 2012/10/08 21:40:41 Still a work in progress? This should be otherwis
466 __ Bind(&fall_through);
467 return false;
468 }
469
470
471 bool Intrinsifier::Uint8Array_setIndexed(Assembler* assembler) {
472 Label fall_through;
473 __ Bind(&fall_through);
474 return false;
475 }
476
477
464 bool Intrinsifier::Uint8Array_getIndexed(Assembler* assembler) { 478 bool Intrinsifier::Uint8Array_getIndexed(Assembler* assembler) {
465 Label fall_through; 479 Label fall_through;
466 TestByteArrayIndex(assembler, &fall_through); 480 TestByteArrayIndex(assembler, &fall_through);
467 __ SmiUntag(R12); 481 __ SmiUntag(R12);
468 __ movzxb(RAX, FieldAddress(RAX, 482 __ movzxb(RAX, FieldAddress(RAX,
469 R12, 483 R12,
470 TIMES_1, 484 TIMES_1,
471 Uint8Array::data_offset())); 485 Uint8Array::data_offset()));
472 __ SmiTag(RAX); 486 __ SmiTag(RAX);
473 __ ret(); 487 __ ret();
(...skipping 978 matching lines...) Expand 10 before | Expand all | Expand 10 after
1452 __ LoadObject(RAX, bool_true); 1466 __ LoadObject(RAX, bool_true);
1453 __ ret(); 1467 __ ret();
1454 return true; 1468 return true;
1455 } 1469 }
1456 1470
1457 #undef __ 1471 #undef __
1458 1472
1459 } // namespace dart 1473 } // namespace dart
1460 1474
1461 #endif // defined TARGET_ARCH_X64 1475 #endif // defined TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698