Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/ui/toolbar/action_box_menu_model.cc

Issue 11073009: Include individual share intents in the action box and allow direct triggering without an intermedi… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: addressing review nits Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/action_box_button_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/action_box_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/action_box_menu_model.cc b/chrome/browser/ui/toolbar/action_box_menu_model.cc
index dfb3ec374d5342cd84c5faa74ff82893526fa464..f661e345c67aff531a84314b7fdd2c599d755040 100644
--- a/chrome/browser/ui/toolbar/action_box_menu_model.cc
+++ b/chrome/browser/ui/toolbar/action_box_menu_model.cc
@@ -52,15 +52,6 @@ ActionBoxMenuModel::ActionBoxMenuModel(Browser* browser,
starred ? IDS_TOOLTIP_STARRED : IDS_TOOLTIP_STAR);
SetIcon(GetIndexOfCommandId(IDC_BOOKMARK_PAGE),
rb.GetNativeImageNamed(starred ? IDR_STAR_LIT : IDR_STAR));
-
- // Since web intents are not working in incognito window (issue 142463),
- // hide "share this page" menu item in incognito mode
- // till the issue gets fixed.
- if (!browser_->profile()->IsOffTheRecord()) {
- AddItemWithStringId(IDC_SHARE_PAGE, IDS_SHARE_PAGE);
- SetIcon(GetIndexOfCommandId(IDC_SHARE_PAGE),
- rb.GetNativeImageNamed(IDR_SHARE));
- }
}
ActionBoxMenuModel::~ActionBoxMenuModel() {
« no previous file with comments | « chrome/browser/ui/toolbar/action_box_button_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698