chrome/browser/ui/browser_command_controller.cc - Issue 11073009: Include individual share intents in the action box and allow direct triggering without an intermedi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 11073009: Include individual share intents in the action box and allow direct triggering without an intermedi… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: addressing review nits Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index aa9fd71bb2c8cb56bb371d25e287094e8009c8cd..7ad7d34f7d489dbcdda2bf0cc5aebf8fca44fe40 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -444,9 +444,6 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

case IDC_BOOKMARK_PAGE:

BookmarkCurrentPage(browser_);

break;

- case IDC_SHARE_PAGE:

- ShareCurrentPage(browser_);

- break;

case IDC_PIN_TO_START_SCREEN:

TogglePagePinnedToStartScreen(browser_);

break;

@@ -836,7 +833,6 @@ void BrowserCommandController::InitCommandState() {

command_updater_.UpdateCommandEnabled(IDC_ENCODING_ISO88598I, true);

command_updater_.UpdateCommandEnabled(IDC_ENCODING_WINDOWS1255, true);

command_updater_.UpdateCommandEnabled(IDC_ENCODING_WINDOWS1258, true);

- command_updater_.UpdateCommandEnabled(IDC_SHARE_PAGE, true);

// Zoom

command_updater_.UpdateCommandEnabled(IDC_ZOOM_MENU, true);

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/browser_commands.h » ('j') | no next file with comments »