Include individual share intents in the action box and allow direct triggering without an intermedi…

chrome/browser/ui/toolbar/action_box_button_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TOOLBAR_ACTION_BOX_BUTTON_CONTROLLER_H_
 #define CHROME_BROWSER_UI_TOOLBAR_ACTION_BOX_BUTTON_CONTROLLER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 50 matching lines @@
   int GetCommandIdForExtension(const extensions::Extension& extension);
 
   // Gets the extension for a command ID, or NULL if there isn't one.
   const extensions::Extension* GetExtensionForCommandId(int command_id);
 
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
+  // Handles "share with X" commands.
+  void TriggerExplicitShareIntent(const GURL& share_service_url);
+
+  // Handles the "Find places to share" command. Navigates the browser to the
+  // web store to find extensions with share intents.
+  void NavigateToWebStoreShareIntentsList();
+
   Browser* browser_;
 
   Delegate* delegate_;
 
   // The command ID to assign to the next extension that needs one.

[Peter Kasting, 2012/10/15 19:33:09]

Nit: Comment is wrong

[skare_, 2012/10/15 21:07:27]

removed member
On 2012/10/15 19:33:09, Peter Kasting wrote:

+  int next_share_intent_command_id_;
+
+  // The share service strings that have commands associated with them.
+  typedef std::map<int, GURL> ShareIntentServiceCommandMap;
+  ShareIntentServiceCommandMap share_intent_service_ids_;
+
+  // The command ID to assign to the next extension that needs one.
   int next_extension_command_id_;
 
   // The extension IDs that have commands associated with them.
   typedef std::map<std::string, int> ExtensionIdCommandMap;
   ExtensionIdCommandMap extension_command_ids_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ActionBoxButtonController);
 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_ACTION_BOX_BUTTON_CONTROLLER_H_